Skip to content

Refactor on config_manager.py #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pan-x-c merged 17 commits into from
Apr 28, 2025
Merged

Refactor on config_manager.py #23

pan-x-c merged 17 commits into from
Apr 28, 2025

Conversation

@chenyushuo
Copy link
Collaborator

@chenyushuo chenyushuo commented Apr 25, 2025 •
edited
Loading

Description

Refactor on config_manager.py:

  1. Add beginer mode.
  2. Simplify configs.
  3. Add more help message on configs.
  4. Rename total_epoch to total_epochs.
  5. Add some veRL configs (norm_adv_by_std_in_grpo, use_kl_in_reward, horizon and target_kl).
  6. buffer.train_dataset.algorithm_type will be set to trainer.algorithm_type automatically, and buffer.sft_warmup_dataset.algorithm_type will be set to AlgorithmType.SFT automatically.
  7. Support setting trainer_config directly without providing trainer_config_path.
  8. algorithm_type in dataset will be set automatically.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

hiyuchang
hiyuchang reviewed Apr 25, 2025
View reviewed changes
hiyuchang
hiyuchang reviewed Apr 25, 2025
View reviewed changes
hiyuchang
hiyuchang reviewed Apr 25, 2025
View reviewed changes
hiyuchang
hiyuchang reviewed Apr 25, 2025
View reviewed changes
hiyuchang
hiyuchang reviewed Apr 25, 2025
View reviewed changes
hiyuchang
hiyuchang reviewed Apr 25, 2025
View reviewed changes
hiyuchang
hiyuchang reviewed Apr 25, 2025
View reviewed changes
hiyuchang
hiyuchang reviewed Apr 25, 2025
View reviewed changes
yanxi-chen
yanxi-chen reviewed Apr 27, 2025
View reviewed changes
yanxi-chen
yanxi-chen reviewed Apr 27, 2025
View reviewed changes
yanxi-chen
yanxi-chen reviewed Apr 27, 2025
View reviewed changes
yanxi-chen
yanxi-chen reviewed Apr 27, 2025
View reviewed changes
hiyuchang
hiyuchang reviewed Apr 27, 2025
View reviewed changes
hiyuchang
hiyuchang reviewed Apr 27, 2025
View reviewed changes
@pan-x-c
Copy link
Collaborator

pan-x-c commented Apr 27, 2025

/run-unittest

@github-actions
Copy link

github-actions bot commented Apr 27, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
13 13 0 0 0 0 0 99ms

Failed Tests

No failed tests ✨

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name Status Flaky Duration
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer ✅ 1ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid ✅ 1ms
tests/common/config_test.py::TestConfig::test_load_default_config ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion ✅ 1ms
tests/common/vllm_test.py::TestModelWrapperSync::test_generate ✅ 41ms
tests/common/vllm_test.py::TestModelWrapperAsync::test_generate ✅ 40ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask ✅ 1ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool ✅ 13ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow ✅ 1ms

Github Test Reporter by CTRF 💚

pan-x-c
pan-x-c reviewed Apr 27, 2025
View reviewed changes
Copy link
Collaborator

@pan-x-c pan-x-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the inline comments, others LGTM

@pan-x-c pan-x-c merged commit d66b3de into modelscope:main Apr 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hiyuchang hiyuchang hiyuchang left review comments

@yanxi-chen yanxi-chen yanxi-chen left review comments

@pan-x-c pan-x-c pan-x-c approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chenyushuo @pan-x-c @hiyuchang @yanxi-chen